Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix failure in silhouette_alist #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sjsrey merged 1 commit into from
Nov 14, 2022
Merged

Fix failure in silhouette_alist #218

sjsrey merged 1 commit into from
Nov 14, 2022

Conversation

@sjsrey
Copy link
Member

@sjsrey sjsrey commented Sep 16, 2022 •
edited by jGaboardi
Loading

This resolves #210

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #218 (8bf38d9) into master (4970862) will decrease coverage by 3.36%.
The diff coverage is 65.83%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   77.33%   73.96%   -3.37%     
==========================================
  Files          45       45              
  Lines        4941     4878      -63     
==========================================
- Hits         3821     3608     -213     
- Misses       1120     1270     +150
Impacted Files Coverage Δ
esda/adbscan.py 90.51% <ø> (-2.92%) ⬇️
esda/crand.py 90.78% <ø> (-0.18%) ⬇️
esda/join_counts_local.py 100.00% <ø> (ø)
esda/join_counts_local_bv.py 97.36% <ø> (-0.10%) ⬇️
esda/join_counts_local_mv.py 100.00% <ø> (ø)
esda/lee.py 17.77% <ø> (-2.66%) ⬇️
esda/losh.py 89.47% <ø> (-0.27%) ⬇️
esda/map_comparison.py 89.65% <ø> (ø)
esda/moran.py 78.10% <ø> (-0.32%) ⬇️
esda/shape.py 16.66% <ø> (-55.10%) ⬇️
... and 35 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jGaboardi
jGaboardi approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@jGaboardi jGaboardi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjsrey Shall we go ahead and merge this to start whittling down the errors and warnings so we can get back to green? It would help weed out other failures. Same goes for #217.

xref #224 #222 #219

@sjsrey sjsrey merged commit 7c653d5 into pysal:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jGaboardi jGaboardi jGaboardi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_silhouette_alist failures

2 participants

@sjsrey @jGaboardi