Thanks to visit codestin.com
Credit goes to github.com

Skip to content

xfail 2 tests using scikit-learn for DBSCAN #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jGaboardi merged 6 commits into from
Nov 15, 2022
Merged

xfail 2 tests using scikit-learn for DBSCAN #225

jGaboardi merged 6 commits into from
Nov 15, 2022

Conversation

@jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Nov 14, 2022 •
edited
Loading

This PR provides a temporary solution to #219 until we figure out what's going on with scikit-learn==1.1.3.

@codecov
Copy link

codecov bot commented Nov 14, 2022 •
edited
Loading

Codecov Report

Merging #225 (d55c8d6) into master (d93058c) will increase coverage by 0.70%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
+ Coverage   76.72%   77.43%   +0.70%     
==========================================
  Files          44       44              
  Lines        4856     4923      +67     
==========================================
+ Hits         3726     3812      +86     
+ Misses       1130     1111      -19
Impacted Files Coverage Δ
esda/tests/test_adbscan.py 97.87% <100.00%> (+0.07%) ⬆️
esda/geary_local_mv.py 100.00% <0.00%> (ø)
esda/tests/test_smaup.py 100.00% <0.00%> (ø)
esda/join_counts_local.py 100.00% <0.00%> (ø)
esda/join_counts_local_mv.py 100.00% <0.00%> (ø)
esda/tests/test_gamma.py 97.40% <0.00%> (+0.03%) ⬆️
esda/geary.py 96.25% <0.00%> (+0.04%) ⬆️
esda/join_counts.py 97.16% <0.00%> (+0.05%) ⬆️
esda/tests/test_geary.py 96.72% <0.00%> (+0.05%) ⬆️
esda/tests/test_join_counts.py 96.66% <0.00%> (+0.05%) ⬆️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jGaboardi jGaboardi self-assigned this Nov 14, 2022
@jGaboardi jGaboardi added the dependencies Pull requests that update a dependency file label Nov 14, 2022
@martinfleis
Copy link
Member

martinfleis commented Nov 14, 2022

Strictly speaking, we do not require ==1.0.2 but <1.1.3 or <1.1 don't we?

@jGaboardi
Copy link
Member Author

jGaboardi commented Nov 14, 2022

Strictly speaking, we do not require ==1.0.2 but <1.1.3 or <1.1 don't we?

Good point. Will update.

martinfleis
martinfleis reviewed Nov 14, 2022
View reviewed changes
@jGaboardi @martinfleis
Update environment.yml
be74b4d 
Co-authored-by: Martin Fleischmann <[email protected]>
martinfleis
martinfleis approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also look into the cause of the failure in 1.1, this is not a sustainable solution.

@jGaboardi
Copy link
Member Author

jGaboardi commented Nov 14, 2022

We should also look into the cause of the failure in 1.1, this is not a sustainable solution.

Much agreed. This is merely to get CI green again for modernization efforts so two failing tests don't completely stop development.

@martinfleis
Copy link
Member

martinfleis commented Nov 14, 2022

This is merely to get CI green again for modernization efforts so two failing tests don't completely stop development.

Wouldn't a better solution be an xfail mark then?

@jGaboardi
Copy link
Member Author

jGaboardi commented Nov 14, 2022

Wouldn't a better solution be an xfail mark then?

Probably, yes. Will update accordingly.

@jGaboardi jGaboardi changed the title pin scikit-learn==1.0.2 xfail 2 tests using scikit-learn for DBSCAN Nov 14, 2022
martinfleis
martinfleis reviewed Nov 14, 2022
View reviewed changes
@jGaboardi @martinfleis
Update environment.yml
d55c8d6 
Co-authored-by: Martin Fleischmann <[email protected]>
@jGaboardi jGaboardi merged commit 8ca012f into pysal:master Nov 15, 2022
@jGaboardi jGaboardi deleted the pin_scikit_learn branch November 15, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinfleis martinfleis martinfleis approved these changes

@sjsrey sjsrey Awaiting requested review from sjsrey

@knaaptime knaaptime Awaiting requested review from knaaptime

Assignees

@jGaboardi jGaboardi

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jGaboardi @martinfleis