future warn for .by_col() methods #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
=======================================
+ Coverage 73.0% 73.1% +0.1%
=======================================
Files 24 24
Lines 3246 3269 +23
Branches 519 519
=======================================
+ Hits 2369 2390 +21
- Misses 709 711 +2
Partials 168 168
|
sjsrey
approved these changes
Dec 11, 2022
Member
Author
|
@sjsrey shall we go ahead and merge this? |
sjsrey
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
FutureWarnings to all.by_col()methods as a start for deprecation.