update to pyproject #256
Merged
update to pyproject #256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfleis
reviewed
Jul 28, 2023
martinfleis
reviewed
Aug 3, 2023
esda/__init__.py
Outdated
| import contextlib | ||
| from importlib.metadata import PackageNotFoundError, version | ||
|
|
||
| from . import _version, adbscan, shape # noqa F401 |
Member
There was a problem hiding this comment.
Suggested change
| from . import _version, adbscan, shape # noqa F401 | |
| from . import adbscan, shape # noqa F401 |
this probably should not be there?
jGaboardi
requested changes
Aug 3, 2023
Member
jGaboardi
left a comment
There was a problem hiding this comment.
All looks well after addressing @martinfleis's comment
esda/__init__.py
Outdated
| import contextlib | ||
| from importlib.metadata import PackageNotFoundError, version | ||
|
|
||
| from . import _version, adbscan, shape # noqa F401 |
Member
Author
|
ok i think i got the last piece |
sjsrey
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.