CI: properly test min and dev #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This looks as expected now. The envs with old pin pass, latest fail due to scikit-learn regression, dev passes again as that regression was fixed on sklearn main. I have also updated pins in requirements to reflect the actual minimum (or at least tested minimum). |
martinfleis
commented
Aug 3, 2023
Member
@martinfleis is there a specific issue or PR over in |
Member
Author
|
@jGaboardi I suppose scikit-learn/scikit-learn#26772 |
knaaptime
pushed a commit
to knaaptime/esda
that referenced
this pull request
Aug 4, 2023
* CI: properly test min and dev * better pins * fix nightly index * pin scipy to actual min req * update requirements.txt
jGaboardi
added a commit
that referenced
this pull request
Sep 25, 2025
* add first draft of correlogram * add comment to include geoda version * add correlogram test * typos, test func * add explanation and some notebook text * update to pyproject * scm init * update release workflow * use radius * CI: properly test min and dev (#258) * CI: properly test min and dev * better pins * fix nightly index * pin scipy to actual min req * update requirements.txt * rebase * rm manifest * double comment * callable * knn test * formatting * local import * fix whitespace for test rerun * Update esda/correlogram.py Co-authored-by: James Gaboardi <[email protected]> * add first draft of nonparametric correlogram * only estimate upper triangle for performance reasons; fix import * if precomputed, check symmetry and still run upper triangular lowess * swap shaping and move to more specific class name * add docs for lowess_correlogram * swap to lowess correlogram and ruff * validate, fix typehints, etc. * make naming swaps * improve binning logic * continue fleshing out tests * span half the bounding box by default * address colocation issues in lowess correlogram * finalize bin approach, fix bugs and tests * move back to libpysal for compat * update tests for compat too * add skip for min environments that do not have statsmodels * catch runtime warnings during statistic estimation * clean up notebook plots and add nonparametric * add to api docs * fix notebook * fix docstring rendering --------- Co-authored-by: Martin Fleischmann <[email protected]> Co-authored-by: Levi John Wolf <[email protected]> Co-authored-by: James Gaboardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to CI environments to ensure that we check against minimal supported versions as well as against dev versions. That ensures that issues like #254 are caught sooner and that we know it affects only some versions of dependencies.