Adjust imports to updates in libpysal
#272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ov/codecov-action-4 Bump codecov/codecov-action from 3 to 4
Codecov Report
@@ Coverage Diff @@
## main #272 +/- ##
=====================================
Coverage 73.4% 73.4%
=====================================
Files 24 24
Lines 3284 3285 +1
Branches 518 518
=====================================
+ Hits 2410 2411 +1
Misses 708 708
Partials 166 166
|
martinfleis
reviewed
Oct 24, 2023
Member
martinfleis
left a comment
There was a problem hiding this comment.
This is an interesting pattern...
Co-authored-by: Martin Fleischmann <[email protected]>
martinfleis
approved these changes
Oct 24, 2023
Member
|
We will need to release this before the next lib will come. Just a note. |
Member
Author
|
Any blockers at the moment? No time like the present. |
Closed
Member
|
We could easily do a patch just with this but also can wait. I don't assume lib will have a next release before end of the year. |
Member
Author
|
So would it hurt to have an |
Member
no, better be ready.
no need for that, we're not fixing anything a user would care about |
Member
Author
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libpysal.common#271.libpysal.commonlibpysal#605