make matplotlib optional #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
good call |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=======================================
- Coverage 81.3% 81.2% -0.1%
=======================================
Files 24 24
Lines 3331 3332 +1
=======================================
- Hits 2709 2706 -3
- Misses 622 626 +4
|
gegen07
requested changes
Aug 3, 2024
Member
|
Let's also remove |
Member
|
And move |
jGaboardi
approved these changes
Aug 6, 2024
Member
|
@jGaboardi if you want to have an env without matplotlib in min, we'll need to change geopandas to geopandas-base. Otherwise geopandas will pull it no matter if it is listed in our yaml file. |
Member
Good call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now matplotlib is an implicit dependency of the library. By moving the import statement inside the function that uses it, esda will no longer break consumers that dont take a dependency on matplotlib explicitly.