Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.6%. Comparing base (e095b21) to head (51db7ab).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##            main    #356     +/-   ##
=======================================
+ Coverage   81.3%   81.6%   +0.2%     
=======================================
  Files         24      24             
  Lines       3335    3372     +37     
=======================================
+ Hits        2713    2750     +37     
  Misses       622     622             

i like the idea that functions map to verbs whenever possible so i'd vote for maybe plot_scatter even though its the most different? i dunno

As a follow up, I want to figure out a smart way of colour customisation but didn't give it much thought yet.

if you ignore insignificant (or put it in the middle), then it should always be in order for a diverging colormap, then you can set nonsig separately? Like currently if you give Local_Moran.explore(cmap='coolwarm_r') it'll do the right thing, IIRC

Like currently if you give Local_Moran.explore(cmap='coolwarm_r') it'll do the right thing, IIRC

Only if you have all 5 clusters present. If you, for example, don't have Low-High in your result, the mapping will become inconsistent.

That's true but if you're sending your own cmap then youre taking that risk onto yourself imo. Choosing your own style means you might be choosing something misleading

@jGaboardi where does the need to add full stops at the end of arg descriptions come from? Is that some style I am not aware of? Those are mostly not sentences that would require it from grammar perspective no?

It is simply my preference, as I think it's cleaner and more 'kept' looking. I'd not be offended if you did not accept the changes.

Regarding the API, should we go with plot_scatterplot or just simply scatterplot?

i like the idea that functions map to verbs whenever possible so i'd vote for maybe plot_scatter even though its the most different? I dunno

@knaaptime I always thought that "scatter" in scatter plot is an adjective no? Is it also a noun?

@jGaboardi @sjsrey what is your take on the API?

splot currently uses moran_scatterplot

i dunno english is ugly and this gets tricky. Technically 'scatterplot' is a noun.

...but I agree, i interpret the same way; "plot" is the verb, and scatter modifies the plot, so scatter is the adjective (which makes scatterplot an adverb?). I guess what I'm saying is 'pure' verbs are clearer than adverbs? Thus I prefer attempting to make things explicit: "plot the scatter", in which case scatter is a noun (the type of graph) and plotting is what we do to it

but really, its late and I'm not picky. I defer to your judgment :)

Regarding the API, should we go with plot_scatterplot or just simply scatterplot?

i like the idea that functions map to verbs whenever possible so i'd vote for maybe plot_scatter even though its the most different? I dunno

@knaaptime I always thought that "scatter" in scatter plot is an adjective no? Is it also a noun?

@jGaboardi @sjsrey what is your take on the API?

splot currently uses moran_scatterplot

+1 on plot_scatter

API and current naming (plot_scatter) look OK t me.