ENH: add Moran.plot_simulation and Moran_BV.plot_simulation #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
=======================================
- Coverage 81.6% 81.5% -0.0%
=======================================
Files 24 24
Lines 3372 3391 +19
=======================================
+ Hits 2750 2765 +15
- Misses 622 626 +4
|
sjsrey
reviewed
Jan 4, 2025
jGaboardi
approved these changes
Jan 4, 2025
Co-authored-by: James Gaboardi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another port from splot, this time
plot_simulation. Droppingaspect_equalkeyword as it does not make sense here given the two axes are using distinct units.I have also added labels to vertical lines indicating I and EI, so that they show up in legend if you do
plt.legend().