fix indexing issue with adjlist construction #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Possibly related to and fix for pysal/spopt#346 |
Codecov Report
@@ Coverage Diff @@
## main #528 +/- ##
=======================================
+ Coverage 79.9% 79.9% +0.1%
=======================================
Files 113 113
Lines 13130 13135 +5
=======================================
+ Hits 10486 10500 +14
+ Misses 2644 2635 -9
|
martinfleis
approved these changes
May 24, 2023
Member
martinfleis
left a comment
There was a problem hiding this comment.
Thanks!
We really need to get rid of ordering... It is a can of worms and I'm sure this is not the only bug that is in there.
ljwolf
referenced
this pull request
May 25, 2023
* Handle set_index properly in to_adjlist * Add option to sort/unsort return from to_adjlist * Update libpysal/weights/tests/test_adjlist.py Co-authored-by: Martin Fleischmann <[email protected]> Co-authored-by: eli knaap <[email protected]> Co-authored-by: Martin Fleischmann <[email protected]>
This was referenced May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see my comment in pysal/esda#245 for rationale and the fix implemented here.