Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove xarray as hard dependency #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 5, 2023
Merged

remove xarray as hard dependency #629

merged 5 commits into from
Nov 5, 2023

Conversation

@jGaboardi
Copy link
Member

This PR removes xarray as hard dependency, which is causing feedstock failures

@jGaboardi jGaboardi self-assigned this Nov 4, 2023
@jGaboardi jGaboardi added maintenance dependencies Pull requests that update a dependency file labels Nov 4, 2023
@jGaboardi
Copy link
Member Author

So with these two failures in test_contiguity.py and test_raster.py , do we want to skipif?

@codecov
Copy link

codecov bot commented Nov 4, 2023 •
edited
Loading

Codecov Report

Merging #629 (c170807) into main (6072541) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #629   +/-   ##
=====================================
  Coverage   84.5%   84.5%           
=====================================
  Files        139     139           
  Lines      14967   14972    +5     
=====================================
+ Hits       12642   12647    +5     
  Misses      2325    2325
Files Coverage Δ
libpysal/weights/tests/test_contiguity.py 100.0% <100.0%> (ø)
libpysal/weights/tests/test_raster.py 100.0% <100.0%> (ø)

@jGaboardi
Copy link
Member Author

So unless I am missing something obvious we have 2 choices here:

  1. Do some minor(?) refactoring in test_contiguity.ContiguityMixin where the da stuff is mixed in with other stuff; or
  2. Add xarray to the "testing" section of ci/312-no-optional.yaml

@jGaboardi jGaboardi mentioned this pull request Nov 5, 2023
Merged
@jGaboardi
Copy link
Member Author

@knaaptime OK, CI running now. Sorry for the confusion 🤣

knaaptime
knaaptime reviewed Nov 5, 2023
View reviewed changes
@jGaboardi
Copy link
Member Author

So is this PR good to merge? And after merge shall we cut a v4.9.2 release? or v4.9.1post1? Or something else?

@knaaptime
Copy link
Member

i think this is a bugfix (and we're changing the dependencies) so id do 492. I think its probably ready to go, but was gonna wait for martin to have a look since you and i both touched the pr

@jGaboardi
Copy link
Member Author

Agreed

martinfleis
martinfleis reviewed Nov 5, 2023
View reviewed changes
martinfleis
martinfleis approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending green ci :)

@jGaboardi jGaboardi requested a review from martinfleis November 5, 2023 19:31
@jGaboardi jGaboardi merged commit 44204b5 into pysal:main Nov 5, 2023
@jGaboardi jGaboardi deleted the remove_xarray_hard_dep branch November 5, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@knaaptime knaaptime knaaptime approved these changes

@martinfleis martinfleis Awaiting requested review from martinfleis

Assignees

@jGaboardi jGaboardi

Labels

dependencies Pull requests that update a dependency file maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jGaboardi @knaaptime @martinfleis