BUG: incorrect gaussian kernel on Graph #789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
=====================================
Coverage 85.4% 85.4%
=====================================
Files 150 150
Lines 16012 16006 -6
=====================================
- Hits 13673 13669 -4
+ Misses 2339 2337 -2
🚀 New features to boost your workflow:
|
|
See also #790 as while this results in the same as W, I am not sure if either of those is correct... |
|
Can you provide a link to the GeoDa implementation? |
|
GeoDa is here https://github.com/GeoDaCenter/geoda/blob/0162b8150a949a2d6b8853eec546d48e25ab79f9/Weights/DistUtils.cpp#L361 but I have also tested that empirically by running GeoDa. The fix here is matching the W implementation here libpysal/libpysal/weights/distance.py Lines 698 to 700 in dd862be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting W code to vectorized Graph code, we made a mistake in the placement of brackets, resulting in deviation form W and GeoDa implementation.