Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

TST: ensure EEA large rivers are downloaded prior running tests, numpy compat, plotting text fix#818

Merged
jGaboardi merged 5 commits intopysal:mainfrom
martinfleis:tst-eea
Dec 23, 2025
Merged

TST: ensure EEA large rivers are downloaded prior running tests, numpy compat, plotting text fix#818
jGaboardi merged 5 commits intopysal:mainfrom
martinfleis:tst-eea

Conversation

@martinfleis
Copy link
Member

No description provided.

@martinfleis
Copy link
Member Author

It seems that using Zenodo as a backup data storage was not as smart as I thought it would be. Seems to be heavily throttled so after 4 successful fetches from individual workers within a short time, the rest is blocked.

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.4%. Comparing base (e47859e) to head (22bd9fd).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #818   +/-   ##
=====================================
  Coverage   85.4%   85.4%           
=====================================
  Files        150     150           
  Lines      15954   15962    +8     
=====================================
+ Hits       13620   13629    +9     
+ Misses      2334    2333    -1     
Files with missing lines Coverage Δ
libpysal/graph/tests/test_kernel.py 99.1% <100.0%> (ø)
libpysal/weights/tests/test_weights.py 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martinfleis
Copy link
Member Author

I cut a new release of geodatasets linking to Github url instead of Zenodo. That seems to solve the issue. In any case, we should pre-fetch the data.

@martinfleis martinfleis changed the title TST: ensure EEA large rivers are downloaded prior running tests TST: ensure EEA large rivers are downloaded prior running tests, numpy compat, plotting text fix Dec 23, 2025
@martinfleis
Copy link
Member Author

I also pushed fixes to rest of the tests, so we're green.

@jGaboardi jGaboardi merged commit d222c9b into pysal:main Dec 23, 2025
12 checks passed
@martinfleis martinfleis deleted the tst-eea branch December 23, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants