fix error and API for quadrat based statistics #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 52.47% 52.74% +0.27%
==========================================
Files 12 12
Lines 1841 1841
Branches 315 315
==========================================
+ Hits 966 971 +5
+ Misses 819 815 -4
+ Partials 56 55 -1
|
Member
|
Good fix @weikang9009! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix an error and missing attributes for quadrat-based statistics:
andshould be used instead of&as the logical operator between two float numbersrectangle_widthandrectangle_heightare attributes ofRectangleMbut are missing in the docstringsrectangle_widthandrectangle_heightto the constructor method ofQStatisticto allow users to pass width and height of the grid cells in addition to the number of cells