Check feasibility following solution attempt #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #239 +/- ##
=======================================
+ Coverage 65.9% 66.3% +0.3%
=======================================
Files 23 23
Lines 2554 2564 +10
Branches 559 560 +1
=======================================
+ Hits 1684 1699 +15
+ Misses 788 779 -9
- Partials 82 86 +4
|
Member
|
@jGaboardi Sorry for adding commits to your pull request. I just changed the parameter name |
Member
Author
No problem! All looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #238 by adding a
check_status()method withinLocateSolverthe is collected directly after a solution attempt in each model's respectivesolve()methods. It raises aRuntimeErrorif the status is anything but optimal. Tests for infeasibility are also updated.xref #238, #237
cc @qszhao