LSCP-B #259
LSCP-B #259
Conversation
Codecov Report
@@ Coverage Diff @@
## main #259 +/- ##
=======================================
+ Coverage 66.1% 67.2% +1.1%
=======================================
Files 23 23
Lines 2582 2659 +77
Branches 566 583 +17
=======================================
+ Hits 1706 1787 +81
+ Misses 790 781 -9
- Partials 86 91 +5
|
jGaboardi
left a comment
There was a problem hiding this comment.
Phenomenal work, @erinrolson! This is a great start here! I think next we need to think about:
- adding in tests for the LSCP-B; and
- creating a notebook demonstrating the LSCP-B
|
cc @qszhao |
|
@erinrolson Let's remove the |
|
@erinrolson I think after removing the |
gegen07
left a comment
There was a problem hiding this comment.
- Could you run the lscpb notebook from the beginning? It starts from 30th cell.
- Maybe we can add the
plot_resultsfunction toutilfile? We are using it in all notebooks. @jGaboardi what do you think?
@erinrolson just small changes to wrap up this awesome work!
@gegen07 This could be a nice idea (though not for this PR). We may also discuss integrating viz functionality with |
|
Thanks @erinrolson for your awesome contribution!! 🎉 |
Implements LSCPB class for GSoC '22