Thanks to visit codestin.com
Credit goes to github.com

Skip to content

testing overhaul, etc #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gegen07 merged 4 commits into from
Oct 17, 2022
Merged

testing overhaul, etc #279

gegen07 merged 4 commits into from
Oct 17, 2022

Conversation

@jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Oct 14, 2022 •
edited
Loading

This PR:

  • black formats repo (because somehow that never happened?)
  • resolves nearly all warnings deprecation warnings in CI
  • converts testing infrastructure from unittest to pytest
  • adds matching for specific warnings & errors and thrown messages from all that are currently tested against.
  • other minor streamlines

@jGaboardi jGaboardi self-assigned this Oct 14, 2022
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #279 (0d7da9e) into main (1be809f) will increase coverage by 5.1%.
The diff coverage is 83.6%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #279     +/-   ##
=======================================
+ Coverage   67.6%   72.6%   +5.1%     
=======================================
  Files         24      23      -1     
  Lines       2717    2387    -330     
  Branches     549     455     -94     
=======================================
- Hits        1836    1734    -102     
+ Misses       792     584    -208     
+ Partials      89      69     -20
Impacted Files Coverage Δ
spopt/BaseClass.py 52.6% <0.0%> (ø)
spopt/locate/base.py 95.0% <ø> (ø)
spopt/locate/p_dispersion.py 90.7% <ø> (ø)
spopt/region/azp.py 34.2% <ø> (ø)
spopt/region/spenc.py 100.0% <ø> (ø)
spopt/region/components.py 41.1% <33.3%> (ø)
spopt/region/objective_function.py 59.6% <33.3%> (ø)
spopt/region/base.py 91.2% <77.3%> (ø)
spopt/locate/coverage.py 99.0% <100.0%> (+<0.1%) ⬆️
spopt/locate/p_center.py 98.5% <100.0%> (+<0.1%) ⬆️
... and 7 more

@jGaboardi jGaboardi requested a review from gegen07 October 14, 2022 17:45
@jGaboardi jGaboardi mentioned this pull request Oct 14, 2022
Open
8 tasks
gegen07
gegen07 reviewed Oct 17, 2022
View reviewed changes
Copy link
Member

@gegen07 gegen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gegen07 gegen07 merged commit 336f235 into pysal:main Oct 17, 2022
@jGaboardi jGaboardi deleted the update_testing branch October 17, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gegen07 gegen07 gegen07 approved these changes

Assignees

@jGaboardi jGaboardi

Labels

CI testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jGaboardi @gegen07