Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
=======================================
+ Coverage 73.3% 73.8% +0.5%
=======================================
Files 23 23
Lines 2452 2456 +4
Branches 475 476 +1
=======================================
+ Hits 1797 1812 +15
+ Misses 591 579 -12
- Partials 64 65 +1
|
sjsrey
reviewed
Dec 18, 2022
|
|
||
| FacilityModelBuilder.add_client_demand_satisfaction_constraint( | ||
| lscp, lscp.problem, r_cli, r_fac | ||
| lscp, lscp.problem, lscp.aij, r_cli, r_fac |
Member
There was a problem hiding this comment.
is it redundant to pass in lscp, lscp.problem, lscp.aij as separate args, when the latter two are attributes/members of the former?
Member
Author
There was a problem hiding this comment.
This is a very good point. I'd say let's open an issue to standard are streamline variable & constraint creation. Then we can merge this PR in and work on that after?
Member
Author
There was a problem hiding this comment.
So I'll go ahead with the merge and get to work on #317.
sjsrey
reviewed
Dec 18, 2022
Member
sjsrey
left a comment
There was a problem hiding this comment.
Looks good. One question for my education more than anything.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: