Clean up the implementation of the capacitated LSCP #329
Conversation
|
@jGaboardi Sorry for the delay. I'll have time to review it tomorrow 😬 |
Awesome! And no worries. Thanks for taking the time (when you have it)! |
gegen07
left a comment
There was a problem hiding this comment.
-
In
Assign simulated points network locationssection, I think there is a typo. It is written The simulated client and facility points do not ahere to network space. It is supposed to be adhere? I noted this word in all notebooks that explain a model. -
There is a typo in
lscp_capacity.ipynbin scenario 4. It is written internel instead of internal.
These questions are perfectionism, all notebooks are brilliant.
|
I love thorough review and greatly appreciate the detailed comb through. I'll make these changes, and then we'll be OK for a merge (if everything else looks OK)? |
This PR resolves #320.