Thanks to visit codestin.com
Credit goes to github.com

Skip to content

stricter linting – follow up #413 #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jGaboardi merged 3 commits into from
Dec 10, 2023
Merged

stricter linting – follow up #413 #418

jGaboardi merged 3 commits into from
Dec 10, 2023

Conversation

@jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Dec 4, 2023 •
edited
Loading

@jGaboardi jGaboardi self-assigned this Dec 4, 2023
@jGaboardi jGaboardi mentioned this pull request Dec 4, 2023
Closed
25 tasks
@codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Merging #418 (a621733) into main (bf7134a) will decrease coverage by 0.0%.
The diff coverage is 98.6%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #418     +/-   ##
=======================================
- Coverage   77.7%   77.7%   -0.0%     
=======================================
  Files         27      27             
  Lines       2636    2634      -2     
=======================================
- Hits        2048    2046      -2     
  Misses       588     588
Files Coverage Δ
spopt/BaseClass.py 73.3% <ø> (ø)
spopt/locate/base.py 94.3% <100.0%> (ø)
spopt/locate/coverage.py 97.8% <ø> (ø)
spopt/locate/p_center.py 100.0% <ø> (ø)
spopt/locate/p_dispersion.py 100.0% <ø> (ø)
spopt/locate/p_median.py 97.2% <ø> (-<0.1%) ⬇️
spopt/locate/util.py 100.0% <ø> (ø)
spopt/region/azp.py 35.8% <100.0%> (ø)
spopt/region/azp_util.py 36.3% <ø> (ø)
spopt/region/base.py 97.6% <100.0%> (ø)
... and 9 more

gegen07
gegen07 reviewed Dec 7, 2023
View reviewed changes
martinfleis
martinfleis reviewed Dec 7, 2023
View reviewed changes
@jGaboardi jGaboardi merged commit 8800d2f into pysal:main Dec 10, 2023
@jGaboardi jGaboardi deleted the reup_linting_rules branch December 10, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinfleis martinfleis martinfleis approved these changes

@gegen07 gegen07 Awaiting requested review from gegen07

Assignees

@jGaboardi jGaboardi

Labels

maintenance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jGaboardi @gegen07 @martinfleis