Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.2%. Comparing base (13ca45e) to head (e31b142).
Report is 10 commits behind head on main.

@@           Coverage Diff           @@
##            main    #486     +/-   ##
=======================================
+ Coverage   77.8%   78.2%   +0.4%     
=======================================
  Files         27      28      +1     
  Lines       2638    2716     +78     
=======================================
+ Hits        2053    2125     +72     
- Misses       585     591      +6     

Need to also add fast_hdbscan to environment.yml

Yeah but it seems that this generally needs newer deps than SPEC0 so not sure if it's worth doing this bump.

Yeah but it seems that this generally needs newer deps than SPEC0 so not sure if it's worth doing this bump.

Is fast_hdbscan not now a requirement? Maybe I overlooked that.

It is only a soft dep. But as you can see from the CI, it does not work with our oldest pins. Possibly numpy/sklearn are too old. So bumping libpysal to 4.10 solves only half of a problem.

Yeah but it seems that this generally needs newer deps than SPEC0 so not sure if it's worth doing this bump.

Let me know when you make a decision.

To remove all the version flags from $SA^3$, we would have to use sklearn 1.6, which is the latest. I can still bump libpysal and add a version check to CI to skip if older, if you think it makes sense. But it won't work with the oldest anyway.

To remove all the version flags from $SA3$ , we would have to use sklearn 1.6, which is the latest. I can still bump libpysal and add a version check to CI to skip if older, if you think it makes sense. But it won't work with the oldest anyway.

I think this is a good compromise. Go for it.