Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Streamlining Unittest CI workflow #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
martinfleis merged 9 commits into from
Mar 29, 2022
Merged

Streamlining Unittest CI workflow #153

martinfleis merged 9 commits into from
Mar 29, 2022

Conversation

@jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Mar 29, 2022

Updating:

  • CI environments
  • requirements*
  • unittest workflow

@jGaboardi jGaboardi self-assigned this Mar 29, 2022
@jGaboardi
Copy link
Member Author

jGaboardi commented Mar 29, 2022

This pass locally (Python 3.10, macOS), but it seems may be an issue on Ubuntu. I'll try again without using pytest-xdist.

@jGaboardi
Copy link
Member Author

jGaboardi commented Mar 29, 2022

Removing multicore testing did the trick. All green now.

@jGaboardi jGaboardi changed the title [WIP] Streamlining Unittest CI workflow Streamlining Unittest CI workflow Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022 •
edited
Loading

Codecov Report

Merging #153 (e274169) into main (0679125) will increase coverage by 0.6%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #153     +/-   ##
=======================================
+ Coverage   75.8%   76.4%   +0.6%     
=======================================
  Files         19      19             
  Lines       1570    1570             
=======================================
+ Hits        1190    1199      +9     
+ Misses       380     371      -9
Impacted Files Coverage Δ
splot/_version.py 40.7% <0.0%> (+2.7%) ⬆️

martinfleis
martinfleis approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We should also have a release action here.

@martinfleis martinfleis merged commit 353073b into pysal:main Mar 29, 2022
@jGaboardi jGaboardi deleted the streamline_CI branch March 29, 2022 17:08
@jGaboardi
Copy link
Member Author

jGaboardi commented Mar 29, 2022

Thanks. We should also have a release action here.

@martinfleis Want me to do it or do you want to?

@martinfleis
Copy link
Member

martinfleis commented Mar 29, 2022

@jGaboardi If you can I'd be happy to review it.

@jGaboardi jGaboardi mentioned this pull request Mar 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinfleis martinfleis martinfleis approved these changes

@slumnitz slumnitz Awaiting requested review from slumnitz

Assignees

@jGaboardi jGaboardi

Labels

GitHub Actions testing/CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jGaboardi @martinfleis