Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 9, 2024. It is now read-only.

Conversation

@jGaboardi
Copy link
Member

This PR address both pysal/pysal#1139 and the new libpysal.examples schema introduced in libpysal v4.2.

As far as the try/except block in spvcm.diagnostics (also see below), placing this chunk within the function would have to happen in both summarize and _effective_size (without some [minor] refactoring).

try:
    from rpy2.rinterface import RRuntimeError
    from rpy2.robjects.packages import importr
    from rpy2.robjects.numpy2ri import numpy2ri
    import rpy2.robjects as ro
    ro.conversion.py2ri = numpy2ri
    _coda = importr('coda')
    _HAS_CODA = True
    _HAS_RPY2 = True
except (ImportError, LookupError):
    _HAS_CODA = False
    _HAS_RPY2 = False
except RRuntimeError:
    _HAS_CODA = False
    _HAS_RPY2 = True

@jGaboardi jGaboardi self-assigned this Dec 17, 2019
Copy link
Member

@sjsrey sjsrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in terms of the changes for updated libpysal.

Copy link
Member

@weikang9009 weikang9009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jGaboardi
Copy link
Member Author

#11

@ljwolf ljwolf merged commit 5e43037 into pysal:master Jan 24, 2020
@jGaboardi jGaboardi deleted the import_warnings branch January 24, 2020 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants