apply "ruff --fix check --select=C40 pyscf" #1922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @fchapoton for cleaning up pyscf! Out of interest, why are {} and {:} preferable over set() and dict()? |
Contributor
Author
|
well, usually shorter and convenient |
Collaborator
|
As long as python supports the |
Contributor
Author
|
ok, so should I just close the pull request ? |
Collaborator
|
I'll merge this PR. For future PRs, unless updating the deprecated syntax, simply replacing one syntax by another is not encouraged. |
sunqm
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix many little details about list comprehension, dict, sets, etc