Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fgregg
Copy link

@fgregg fgregg commented Jul 15, 2013

Following @vene, compiling c library and then linking the cython extension to it.

Seems to be working.

TODO,

  • decide on the namespace for the library, pystruct is expecting ad3, which conflicts with the directory structure of AD3, since the cpp source files are in that directory.
  • Cythonize factor_graph.pyx so that cython is not a dependency for installing this library

@amueller
Copy link
Member

As I said in the other thread, renaming to AD3 in pystruct is fine with me. On the other hand it is not very pretty to have the c++ code in one folder and the python code in the other folder and rename the python package to avoid conflicts.

Also, I think introducing another name is more confusing. There is already a namespace for AD3 and Python is included in master.
Actually, I think it would be best if we could move all of it upstream.
If it is only a matter of a setup.py in the main directory, I'm pretty sure @andre-martins could be confinced to merge ;)

@amueller
Copy link
Member

can't we have a python folder that contains an ad3 subfolder? or would that create trouble with the pip-installability?

@fgregg
Copy link
Author

fgregg commented Jul 15, 2013

@amueller, I was thinking the same thing, and the last commit is the right solution I think

@amueller
Copy link
Member

great. is travis still happy?

@fgregg
Copy link
Author

fgregg commented Jul 15, 2013

@amueller
Copy link
Member

Ok, great. I'll merge.
Then i'll move this one to the organization and add you to the organization if you don't mind ;)

amueller added a commit that referenced this pull request Jul 15, 2013
@amueller amueller merged commit ce7fcc1 into pystruct:master Jul 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants