Align builder with pip when backend is missing #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `build-backend` field was missing, we would append the default PEP 518 `requires` to the source tree `requires`. This is in contrast to pip which leaves `requires` unmodified. It was therefore possible to create sdists which pip would not have been able to consume. Closes pypa#107 by way of not modifying the `requires` list.
e0ddf01 to
1180fa0
Compare
|
@gaborbernat next time please wait for more feedback on standing issues like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
build-backendfield was missing, we would append the defaultPEP 518
requiresto the source treerequires. This is in contrastto pip which leaves
requiresunmodified. It was therefore possibleto create sdists which pip would not have been able to consume.
Closes #107 by way of not modifying the
requireslist.