Minor: Remove unnecessary canonicalize_name calls and validate via NormalizedName type
#13585
+41
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
approved these changes
Sep 21, 2025
ichard26
approved these changes
Sep 21, 2025
Interesting, thanks for the info, I'll consider making a follow up PR that more thoroughly minimizes the use of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small follow up to #13581, the
nameattribute of theWheelmodel class is now guaranteed to be canonicalized, this means there are many places where it is now redundant to callcanonicalize_name.To validate this is always true I have set some parameters to use the
NormalizedNametype from packaging, which is the type of the canonicalized name. I tried to keep this fairly minimal, there were many more places where a canonicalized name is always being used but changing the type on all of them started to make this PR a lot bigger than it needed to be.We could also use the
Versiontype for the version attribute instead of a str in theWheelmodel, which would save a couple of calls toVersionelsewhere, but this ended up being non-trivial in theLinkEvaluator.evaluate_linkmethod, so I left it a more brave PR than this one.