Fix docs issue for sphinx-4 #2838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehiepsi
commented
May 11, 2021
|
|
||
| def setup(app): | ||
| app.add_stylesheet('css/pyro.css') | ||
| app.add_css_file('css/pyro.css') |
Member
Author
There was a problem hiding this comment.
add_stylesheet is renamed to add_css_file since version 1.8
Member
Member
Author
There was a problem hiding this comment.
I'm not sure. Probably you got some sort of circular import issues (e.g. from ... import * statement or type annotation...)
Member
There was a problem hiding this comment.
That might be it. I'll dig into it.
OlaRonning
approved these changes
May 11, 2021
Member
OlaRonning
left a comment
There was a problem hiding this comment.
LGTM! Thanks for a quick fix.
fritzo
approved these changes
May 11, 2021
Member
fritzo
left a comment
There was a problem hiding this comment.
Let's check readthedocs after this merges, to ensure latest is still built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a doc issue that is blocking current PRs in #2826.