DirichletMultinomial is_sparse=True dtype error #3446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function __log_beta_1_ cannot handle the argument _is_sparse=True_ due to incorrect data type of instantiating _result = torch.zeros_like(value)_. I propose to add that the dtype should be the same as _alpha_; thus, _result = torch.zeros_like(value, dtype=alpha.dtype)_. The problem arises when: _result[mask] = (torch.lgamma(1 + value) + torch.lgamma(alpha) - torch.lgamma(value + alpha))_, as result[mask].dtype >> torch.int64 and (torch.lgamma(1 + value) + torch.lgamma(alpha) - torch.lgamma(value + alpha)).dtype >> torch.float32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function _log_beta_1 cannot handle the argument is_sparse=True due to incorrect data type of instantiating result = torch.zeros_like(value). I propose to add that the dtype should be the same as alpha; thus, result = torch.zeros_like(value, dtype=alpha.dtype).
The problem arises when:
result[mask] = (torch.lgamma(1 + value) + torch.lgamma(alpha) - torch.lgamma(value + alpha)), as result[mask].dtype >> torch.int64 and (torch.lgamma(1 + value) + torch.lgamma(alpha) - torch.lgamma(value + alpha)).dtype >> torch.float32