Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replace pkg_resources with importlib_metadata #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jorenretel wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Replace pkg_resources with importlib_metadata #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2f8afc
migrated to importlib_metadata to replace pkg_resources is deprecated
jorenretel Aug 22, 2023
618f7c8
migrated to importlib_metadata to replace pkg_resources is deprecated
jorenretel Aug 22, 2023
08071ae
fixing isort
jorenretel Aug 22, 2023
dda07c9
installing importlib_metadata on github actions to run mypy
jorenretel Aug 22, 2023
00bb2a4
put importlib_metadata in correct requirements
jorenretel Aug 22, 2023
5c2bf3c
Merge pull request #1 from jorenretel/use_importlib_metadata
jorenretel Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/install_doctest_lint_typecheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,6 @@ jobs:
- name: mypy
run: |
pip install numpy # for the typing stubs
pip install importlib_metadata # for the typing stubs
python -m pip install pandas-stubs types-setuptools
mypy ncls
4 changes: 2 additions & 2 deletions ncls/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import importlib_metadata
import numpy as np
import pkg_resources

__version__ = pkg_resources.get_distribution("ncls").version
__version__ = importlib_metadata.version("ncls")

from ncls.src.ncls import NCLS64 # type: ignore
from ncls.src.ncls32 import NCLS32 # type: ignore
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ classifiers = [
"Topic :: Scientific/Engineering"
]
keywords = ["ncls", "interval-tree", "genomics"]
dependencies = ["numpy"]
dependencies = ["numpy", "importlib_metadata"]

[project.optional-dependencies]
dev = ["black", "bumpver", "isort", "pip-tools", "pytest"]
Expand Down