delete delayed scaling from torchao.float8 #1753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1753
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c95ecdf with merge base dc0134e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Feb 21, 2025
Summary: Previously we added a deprecation warning for delayed scaling in v0.9.0. Now that the branch cut for v0.9.0 has passed, we are deleting delayed scaling from the codebase to simplify the code. Motivation: 1. delayed scaling adds a lot of complexity 2. we still don't have any customers for delayed scaling, since people prefer to optimize for higher accuracy from dynamic scaling If a need for delayed scaling arises in the future, we can bring it back to a prototype folder in a way that is decoupled from the dynamic scaling code. Test Plan: ``` ./test/float8/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 8d8b801 ghstack-comment-id: 2674970350 Pull Request resolved: #1753
Contributor
Author
|
cc @lw , it's happening! |
y-sq
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously we added a deprecation warning for delayed scaling in v0.9.0.
Now that the branch cut for v0.9.0 has passed, we are deleting delayed
scaling from the codebase to simplify the code.
Motivation:
prefer to optimize for higher accuracy from dynamic scaling
If a need for delayed scaling arises in the future, we can bring it back
to a prototype folder in a way that is decoupled from the dynamic
scaling code.
For more context, see #1680
Python LOC impact:
(source: https://gist.github.com/vkuzo/2c845165e7bfe8933cf1bc24561cd613)
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: