Add profiler and Perfetto UI link #1984
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1984
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 10 PendingAs of commit d9c8cec with merge base 42e1345 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds profiling enhancements and Perfetto UI integration to the microbenchmarks suite.
- Introduces functions to upload trace files and generate a Perfetto UI URL.
- Adds a model profiling function using Torch Profiler.
- Updates benchmark configurations, results printing, and error logging to include profiler output.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| benchmarks/microbenchmarks/utils.py | Adds functions for profiling, trace file upload, and Perfetto UI URL generation. |
| benchmarks/microbenchmarks/test/benchmark_config.yml | Updates configuration to enable profiling for specific benchmarks. |
| benchmarks/microbenchmarks/benchmark_runner.py | Improves error logging and conditional CSV-generation based on benchmark results. |
| benchmarks/microbenchmarks/benchmark_inference.py | Integrates the new profiling function into the benchmarking process. |
Comments suppressed due to low confidence (1)
benchmarks/microbenchmarks/test/benchmark_config.yml:39
- The comment contradicts the value (true) for enable_profiler. Update the comment to accurately reflect that profiling is enabled.
enable_profiler: true # Disable profiling for this model
| DEFAULT_TTL_SEC = 28 * 24 * 60 * 60 | ||
| file_name = os.path.basename(local_path) | ||
| manifold_path = os.path.join( | ||
| MANIFOLD_FOLDER, f"{os.getlogin()}_{str(uuid.uuid4())}_{file_name}" |
There was a problem hiding this comment.
Using os.getlogin() may cause errors in non-interactive environments. Consider using getpass.getuser() for improved robustness.
Suggested change
| MANIFOLD_FOLDER, f"{os.getlogin()}_{str(uuid.uuid4())}_{file_name}" | |
| MANIFOLD_FOLDER, f"{getpass.getuser()}_{str(uuid.uuid4())}_{file_name}" |
This was referenced Apr 1, 2025
jainapurva
added a commit
that referenced
this pull request
Apr 1, 2025
jainapurva
added a commit
that referenced
this pull request
Apr 1, 2025
jainapurva
added a commit
that referenced
this pull request
Apr 1, 2025
jainapurva
added a commit
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.