Fix AO SAM2 issues #2109
Merged
Fix AO SAM2 issues #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2109
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 6 Unrelated FailuresAs of commit b57f40e with merge base d06b3e3 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D73460163 |
|
This pull request was exported from Phabricator. Differential Revision: D73460163 |
a0b4577 to
2a40999
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73460163 |
jlbmorales
added a commit
to jlbmorales/ao
that referenced
this pull request
Apr 22, 2025
Summary: Pull Request resolved: pytorch#2109 SAM2 issues - Whenever ```clear_old_points``` was enabled SAM2 would crash AAS Track mult issues - Enables ```multimask``` flags Rootcaused issues to failed assertion in the following lines in ```sam2_base.py::_track_step:L788```: ``` if prev_sam_mask_logits is not None: assert point_inputs is not None and mask_inputs is None mask_inputs = prev_sam_mask_logits multimask_output = self._use_multimask(is_init_cond_frame, point_inputs) assert mask_inputs is None ``` Whenever ```prev_sam_mask_logits``` has a value it results in a crash. There are several situations where this is expected to be the case including during streamed runs, or when clearing points. Test Plan: aistudio test local aas_track_mult ``` Retrieving package values for `fbcode//ai_demos/server_model_zoo/models/aas_track_mult`: buck2 audit package-values --reuse-current-config fbcode//ai_demos/server_model_zoo/models/aas_track_mult Buck command to find test owners: buck2 uquery --reuse-current-config owner(/data/sandcastle/boxes/fbsource/fbcode/ai_demos/server_model_zoo/models/aas_track_mult/test_aas_track_mult_model.py) -a labels Buck command to invoke a test: buck2 test --reuse-current-config --write-build-id /tmp/.tmpS35tJk --client-metadata language=python --client-metadata id=testify.codelens --client-metadata session_id=d0229502-10cc-45e7-a6f6-6c5c276c2e17 fbcode//ai_demos/server_model_zoo/models/aas_track_mult:tests -- --regex ai_demos/server_model_zoo/models/aas_track_mult:tests \- .*(?:\(.*TestAasTrackMultModel\)$|TestAasTrackMultModel: .*) --run-disabled Buck UI: https://www.internalfb.com/buck2/bf9cbfaa-ae6a-4568-876c-0b128dd474bd Test UI: https://www.internalfb.com/intern/testinfra/testrun/6473924727918606 Network: Up: 0B Down: 0B (reSessionID-8b7877b7-4cf8-4850-ac7b-ee84571b005d) Command: test. Time elapsed: 1:07.6s Tests finished: Pass 4. Fail 0. Fatal 0. Skip 0. Build failure 0 ``` Differential Revision: D73460163 Pulled By: jlbmorales
2a40999 to
5b98e3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73460163 |
jlbmorales
added a commit
to jlbmorales/ao
that referenced
this pull request
Apr 22, 2025
Summary: Pull Request resolved: pytorch#2109 SAM2 issues - Whenever ```clear_old_points``` was enabled SAM2 would crash AAS Track mult issues - Enables ```multimask``` flags Rootcaused issues to failed assertion in the following lines in ```sam2_base.py::_track_step:L788```: ``` if prev_sam_mask_logits is not None: assert point_inputs is not None and mask_inputs is None mask_inputs = prev_sam_mask_logits multimask_output = self._use_multimask(is_init_cond_frame, point_inputs) assert mask_inputs is None ``` Whenever ```prev_sam_mask_logits``` has a value it results in a crash. There are several situations where this is expected to be the case including during streamed runs, or when clearing points. Test Plan: aistudio test local aas_track_mult ``` Retrieving package values for `fbcode//ai_demos/server_model_zoo/models/aas_track_mult`: buck2 audit package-values --reuse-current-config fbcode//ai_demos/server_model_zoo/models/aas_track_mult Buck command to find test owners: buck2 uquery --reuse-current-config owner(/data/sandcastle/boxes/fbsource/fbcode/ai_demos/server_model_zoo/models/aas_track_mult/test_aas_track_mult_model.py) -a labels Buck command to invoke a test: buck2 test --reuse-current-config --write-build-id /tmp/.tmpS35tJk --client-metadata language=python --client-metadata id=testify.codelens --client-metadata session_id=d0229502-10cc-45e7-a6f6-6c5c276c2e17 fbcode//ai_demos/server_model_zoo/models/aas_track_mult:tests -- --regex ai_demos/server_model_zoo/models/aas_track_mult:tests \- .*(?:\(.*TestAasTrackMultModel\)$|TestAasTrackMultModel: .*) --run-disabled Buck UI: https://www.internalfb.com/buck2/bf9cbfaa-ae6a-4568-876c-0b128dd474bd Test UI: https://www.internalfb.com/intern/testinfra/testrun/6473924727918606 Network: Up: 0B Down: 0B (reSessionID-8b7877b7-4cf8-4850-ac7b-ee84571b005d) Command: test. Time elapsed: 1:07.6s Tests finished: Pass 4. Fail 0. Fatal 0. Skip 0. Build failure 0 ``` Differential Revision: D73460163 Pulled By: jlbmorales
5b98e3b to
b3e5cdc
Compare
jerryzh168
approved these changes
Apr 22, 2025
Summary: Pull Request resolved: pytorch#2109 SAM2 issues - Whenever ```clear_old_points``` was enabled SAM2 would crash AAS Track mult issues - Enables ```multimask``` flags Rootcaused issues to failed assertion in the following lines in ```sam2_base.py::_track_step:L788```: ``` if prev_sam_mask_logits is not None: assert point_inputs is not None and mask_inputs is None mask_inputs = prev_sam_mask_logits multimask_output = self._use_multimask(is_init_cond_frame, point_inputs) assert mask_inputs is None ``` Whenever ```prev_sam_mask_logits``` has a value it results in a crash. There are several situations where this is expected to be the case including during streamed runs, or when clearing points. Test Plan: aistudio test local aas_track_mult ``` Retrieving package values for `fbcode//ai_demos/server_model_zoo/models/aas_track_mult`: buck2 audit package-values --reuse-current-config fbcode//ai_demos/server_model_zoo/models/aas_track_mult Buck command to find test owners: buck2 uquery --reuse-current-config owner(/data/sandcastle/boxes/fbsource/fbcode/ai_demos/server_model_zoo/models/aas_track_mult/test_aas_track_mult_model.py) -a labels Buck command to invoke a test: buck2 test --reuse-current-config --write-build-id /tmp/.tmpS35tJk --client-metadata language=python --client-metadata id=testify.codelens --client-metadata session_id=d0229502-10cc-45e7-a6f6-6c5c276c2e17 fbcode//ai_demos/server_model_zoo/models/aas_track_mult:tests -- --regex ai_demos/server_model_zoo/models/aas_track_mult:tests \- .*(?:\(.*TestAasTrackMultModel\)$|TestAasTrackMultModel: .*) --run-disabled Buck UI: https://www.internalfb.com/buck2/bf9cbfaa-ae6a-4568-876c-0b128dd474bd Test UI: https://www.internalfb.com/intern/testinfra/testrun/6473924727918606 Network: Up: 0B Down: 0B (reSessionID-8b7877b7-4cf8-4850-ac7b-ee84571b005d) Command: test. Time elapsed: 1:07.6s Tests finished: Pass 4. Fail 0. Fatal 0. Skip 0. Build failure 0 ``` Differential Revision: D73460163 Pulled By: jlbmorales
|
This pull request was exported from Phabricator. Differential Revision: D73460163 |
b3e5cdc to
b57f40e
Compare
|
@jlbmorales has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Fix AO SAM2 issues (#2109) Summary: Pull Request resolved: #2109 SAM2 issues - Whenever ```clear_old_points``` was enabled SAM2 would crash AAS Track mult issues - Enables ```multimask``` flags Rootcaused issues to failed assertion in the following lines in ```sam2_base.py::_track_step:L788```: ``` if prev_sam_mask_logits is not None: assert point_inputs is not None and mask_inputs is None mask_inputs = prev_sam_mask_logits multimask_output = self._use_multimask(is_init_cond_frame, point_inputs) assert mask_inputs is None ``` Whenever ```prev_sam_mask_logits``` has a value it results in a crash. There are several situations where this is expected to be the case including during streamed runs, or when clearing points. Test Plan: aistudio test local aas_track_mult ``` Retrieving package values for `fbcode//ai_demos/server_model_zoo/models/aas_track_mult`: buck2 audit package-values --reuse-current-config fbcode//ai_demos/server_model_zoo/models/aas_track_mult Buck command to find test owners: buck2 uquery --reuse-current-config owner(/data/sandcastle/boxes/fbsource/fbcode/ai_demos/server_model_zoo/models/aas_track_mult/test_aas_track_mult_model.py) -a labels Buck command to invoke a test: buck2 test --reuse-current-config --write-build-id /tmp/.tmpS35tJk --client-metadata language=python --client-metadata id=testify.codelens --client-metadata session_id=d0229502-10cc-45e7-a6f6-6c5c276c2e17 fbcode//ai_demos/server_model_zoo/models/aas_track_mult:tests -- --regex ai_demos/server_model_zoo/models/aas_track_mult:tests \- .*(?:\(.*TestAasTrackMultModel\)$|TestAasTrackMultModel: .*) --run-disabled Buck UI: https://www.internalfb.com/buck2/bf9cbfaa-ae6a-4568-876c-0b128dd474bd Test UI: https://www.internalfb.com/intern/testinfra/testrun/6473924727918606 Network: Up: 0B Down: 0B (reSessionID-8b7877b7-4cf8-4850-ac7b-ee84571b005d) Command: test. Time elapsed: 1:07.6s Tests finished: Pass 4. Fail 0. Fatal 0. Skip 0. Build failure 0 ``` Differential Revision: D73460163 Pulled By: jlbmorales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
SAM2 issues
clear_old_pointswas enabled SAM2 would crashAAS Track mult issues
multimaskflagsRootcaused issues to failed assertion in the following lines in
sam2_base.py::_track_step:L788:Whenever
prev_sam_mask_logitshas a value it results in a crash. There are several situations where this is expected to be the case including during streamed runs, or when clearing points.Differential Revision: D73460163
Pulled By: jlbmorales