Fix AOPerModuleConfig bug in skipping quantizing modules #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previous logic is problematic in handling skipping modules (None setting), this PR fixes it. Test Plan: pytest test/quantization/test_quant_api.py -k test_ao_per_module_config_skip Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2135
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 27eb72d with merge base 0810f57 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
approved these changes
Apr 26, 2025
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Fix AOPerModuleConfig bug in skipping quantizing modules Summary: Previous logic is problematic in handling skipping modules (None setting), this PR fixes it. Test Plan: pytest test/quantization/test_quant_api.py -k test_ao_per_module_config_skip Reviewers: Subscribers: Tasks: Tags: * add IntxWeightOnlyConfig to torchao.quantization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previous logic is problematic in handling skipping modules (None setting), this PR fixes it.
Test Plan:
pytest test/quantization/test_quant_api.py -k test_ao_per_module_config_skip
Reviewers:
Subscribers:
Tasks:
Tags: