[BE] Fix MPS experimental workflow #2181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By actually running them in the conda env that is being created
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2181
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 6 PendingAs of commit f1d2c8b with merge base c9b9adc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
msaroufim
approved these changes
May 7, 2025
|
does this PR break this? https://github.com/pytorch/ao/actions/runs/14888035472/job/41812796233 |
|
That's extremely unlikely since this a workflow only change to an unrelated workflow. Considering you're linking to a failed nightly job try pinning the torch version to see if that fixes |
|
cc oncall @andrewor14 |
This is fixed separately in #2188 |
andrewor14
pushed a commit
that referenced
this pull request
May 9, 2025
* [BE] Fix MPS tests By actually running them in the conda env that is being created * Update torchao_experimental_test.yml * Update torchao_experimental_test.yml
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
* [BE] Fix MPS tests By actually running them in the conda env that is being created * Update torchao_experimental_test.yml * Update torchao_experimental_test.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By actually running them in the conda env that is being created, rather than rely on system-wide Python
Otherwise, as one can see from https://github.com/pytorch/ao/actions/runs/14861926861/job/41728802819
pip installare not running in the conda environment that were configured for the op, but rather against default Python version installed on the system, which has recently changed to 3.13