Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@odiemm-meta
Copy link
Contributor

Summary: Add configs in aps to allow user to adjust the setting in fp8 experiments

Differential Revision: D75945415

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2328

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit d03a48f with merge base 83663b8 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75945415

odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 6, 2025
Summary:

Add configs in aps to allow user to adjust the setting in fp8 experiments

Differential Revision: D75945415
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75945415

odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 6, 2025
Summary:
Pull Request resolved: pytorch#2328

Add configs in aps to allow user to adjust the setting in fp8 experiments

Differential Revision: D75945415
@yuhuishi-convect yuhuishi-convect added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jun 6, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75945415

odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 6, 2025
Summary:
Pull Request resolved: pytorch#2328

Add configs in aps to allow user to adjust the setting in fp8 experiments

Differential Revision: D75945415
Copy link

@avicizhu avicizhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@y-sq y-sq requested review from danielvegamyhre, drisspg and vkuzo June 6, 2025 23:18
odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 7, 2025
Summary:

Add configs in aps to allow user to adjust the setting in fp8 experiments

Reviewed By: avicizhu

Differential Revision: D75945415
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75945415

odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 7, 2025
Summary:
Pull Request resolved: pytorch#2328

Add configs in aps to allow user to adjust the setting in fp8 experiments

Reviewed By: avicizhu

Differential Revision: D75945415
odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 7, 2025
Summary:

Add configs in aps to allow user to adjust the setting in fp8 experiments

Reviewed By: avicizhu

Differential Revision: D75945415
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75945415

odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 7, 2025
Summary:
Pull Request resolved: pytorch#2328

Add configs in aps to allow user to adjust the setting in fp8 experiments

Reviewed By: avicizhu

Differential Revision: D75945415
@drisspg
Copy link
Contributor

drisspg commented Jun 7, 2025

Can you be sure to run the pre commit hooks

odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 7, 2025
Summary:

Add configs in aps to allow user to adjust the setting in fp8 experiments

Reviewed By: avicizhu

Differential Revision: D75945415
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75945415

odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 7, 2025
Summary:
Pull Request resolved: pytorch#2328

Add configs in aps to allow user to adjust the setting in fp8 experiments

Reviewed By: avicizhu

Differential Revision: D75945415
odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 8, 2025
Summary:

Add configs in aps to allow user to adjust the setting in fp8 experiments

Reviewed By: avicizhu

Differential Revision: D75945415
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75945415

odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 8, 2025
Summary:
Pull Request resolved: pytorch#2328

Add configs in aps to allow user to adjust the setting in fp8 experiments

Reviewed By: avicizhu

Differential Revision: D75945415
odiemm-meta added a commit to odiemm-meta/ao that referenced this pull request Jun 9, 2025
Summary:

Add configs in aps to allow user to adjust the setting in fp8 experiments

Reviewed By: avicizhu

Differential Revision: D75945415
Summary:
Pull Request resolved: pytorch#2328

Add configs in aps to allow user to adjust the setting in fp8 experiments

Reviewed By: avicizhu

Differential Revision: D75945415
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D75945415

@facebook-github-bot facebook-github-bot merged commit 769ffa5 into pytorch:main Jun 10, 2025
16 of 20 checks passed
liangel-02 pushed a commit that referenced this pull request Aug 25, 2025
Differential Revision: D75945415

Pull Request resolved: #2328
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants