Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2397
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a221df9 with merge base e29b9bd ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jerryzh168
approved these changes
Jun 17, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the entire experimental GaLore prototype—including its utilities, kernels, documentation, tests, benchmarks, and third-party submodule—to clean up the repository.
- Deletes all
torchao/prototype/galorecode, docs, and tests - Removes GaLore entries from the prototype README
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| torchao/prototype/galore/utils.py | Removed GaLore utility functions |
| torchao/prototype/galore/kernels/adam_downproj_fused.py | Removed fused Adam+projection Triton kernel |
| torchao/prototype/galore/docs/galore_adam8bit.md | Deleted 8-bit optimizer documentation |
| torchao/prototype/galore/docs/README.md | Deleted GaLore docs index |
| torchao/prototype/galore/README.md | Deleted GaLore prototype README |
| torchao/prototype/README.md | Removed GaLore bullets from prototype code structure |
| third_party/cutlass | Removed Cutlass submodule |
| test/quantization/test_galore_quant.py | Removed GaLore quantization tests |
| test/kernel/test_galore_downproj.py | Removed GaLore down-projection kernel tests |
| test/kernel/test_fused_kernels.py | Removed GaLore fused-kernels tests |
| test/kernel/galore_test_utils.py | Removed GaLore test utilities |
| test/galore/profile_memory_usage.py | Removed GaLore memory profiling script |
| test/galore/README.md | Deleted GaLore tests README |
| benchmarks/fused_benchmark_utils.py | Removed GaLore benchmark utilities |
| benchmarks/bench_galore_fused_kernels.py | Removed GaLore fused-kernels benchmark script |
Closed
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
* Delete Galore * restore cutlass changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a temporarily fashionable technique at the time but didn't get any meaningful adoption so deleting considering we have other more ao'ish alternatives like low bit optimizers
I'll merge, thanks!