Delete obsolete code #1145
Closed
Delete obsolete code #1145
+4
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: One unittest (TestProfiler.test_dump_gpu_metrics) faied due to pytorch#1143 1. there are two lines of obsolete code 2. the expected content of the unittest was not updated. Reviewed By: arsatis Differential Revision: D82625373
f647ed7 to
f035d61
Compare
|
This pull request has been merged in 29a3485. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #1143, there are two lines of obsolete code, which led to an error in the unittest (TestProfiler.test_dump_gpu_metrics).
This commit fixes it by deleting the two lines.
Created from CodeHub with https://fburl.com/edit-in-codehub
Reviewed By: arsatis
Differential Revision: D82625373