Fix HAS_CUPTI_RANGE_PROFILER check #1131
Conversation
11b5710 to
a6ae63b
Compare
| // https://docs.nvidia.com/cupti/main/main.html#evolution-of-the-profiling-apis | ||
| #if defined(USE_CUPTI_RANGE_PROFILER) && defined(CUDART_VERSION) && \ | ||
| CUDART_VERSION >= 10000 && CUDA_VERSION >= 11000 && CUDA_VERSION <= 12060 | ||
| CUDART_VERSION >= 10000 && CUDA_VERSION >= 12060 |
There was a problem hiding this comment.
Not sure this is correct. I recall the range profiler breaking on later versions
There was a problem hiding this comment.
@sraikund16 Can reproduce? Nevertheless, the guard is wrong according to the above comment. If the profile still breaks, we should fix it rather than incorrectly disabling it.
There was a problem hiding this comment.
@cyyever based on the NV link provided, it looks like we can use the current APIs until 13.0 although it is not recommended. However, by 13.0 we will need to use the new APIs as the old ones are deprecated. Either way it would require a rework.
There was a problem hiding this comment.
If the current APIs exist during the whole CUDA 13 cycle, then we have lots of time for refactoring.
Signed-off-by: cyy <[email protected]>
Signed-off-by: cyy <[email protected]>
Signed-off-by: cyy <[email protected]>
Signed-off-by: cyy <[email protected]>
Enable
USE_CUPTI_RANGE_PROFILER.