Don't call getenv in side threads
#984
Conversation
getenv on side threadsgetenv in side threads
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@eqy has updated the pull request. You must reimport the pull request before landing. |
|
@eqy has updated the pull request. You must reimport the pull request before landing. |
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@eqy has updated the pull request. You must reimport the pull request before landing. |
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@eqy has updated the pull request. You must reimport the pull request before landing. |
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@eqy has updated the pull request. You must reimport the pull request before landing. |
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Calling
getenvon side threads is dangerous as it can potentially segfault if the main thread is in the middle of setting environment variables: pytorch/pytorch#134596This PR only calls
getenvonly once during the first call ofisDaemonEnvVarSet(), which is called frominit.Co-authored-by: Nikita Shulga [email protected]