Merged
Conversation
sdesrozis
approved these changes
May 11, 2020
Contributor
sdesrozis
left a comment
There was a problem hiding this comment.
I don't understand yet why lr_finder implies to save trainer but it's a detail :)
| # restore to_save and reset trainer's state | ||
| obj = torch.load(cache_filepath.as_posix()) | ||
| trainer.state = None | ||
| trainer.load_state_dict(obj["trainer"]) |
Contributor
There was a problem hiding this comment.
Can it conflict with others loads ?
Collaborator
Author
There was a problem hiding this comment.
Can it conflict with others loads ?
Which others loads ?
I didn't include trainer's state dict into to_save in order to keep it immutable as Mapping requires...
Contributor
There was a problem hiding this comment.
lr_finder just needs to restore state of trainer, that was a stupid remark !
Collaborator
Author
because when lr finder is run, engine is run too. Thus we need to come back to the initial state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #880
Description:
Check list: