docs: rm type hints in ignite.contrib.handlers (2)#1676
Merged
vfdev-5 merged 16 commits intopytorch:masterfrom Feb 23, 2021
Merged
docs: rm type hints in ignite.contrib.handlers (2)#1676vfdev-5 merged 16 commits intopytorch:masterfrom
vfdev-5 merged 16 commits intopytorch:masterfrom
Conversation
Co-authored-by: vfdev <[email protected]>
vfdev-5
reviewed
Feb 22, 2021
Collaborator
vfdev-5
left a comment
There was a problem hiding this comment.
Thanks a lot for working on that issue @ydcjeff !
I left few comments
vfdev-5
reviewed
Feb 23, 2021
vfdev-5
approved these changes
Feb 23, 2021
vfdev-5
added a commit
that referenced
this pull request
Mar 1, 2021
* docs: only show type hints in docstring * Apply suggestions from code review Co-authored-by: vfdev <[email protected]> * fix(docs): correctly link to missing links * docs: rm type hints in docstring of ignite.contrib.handlers * docs: rm type hints in docstring of ignite.contrib.handlers * Apply suggestions from code review Co-authored-by: vfdev <[email protected]> * review: apply suggestions * fix: no return in __init__ * fix: return None in no argument __init__ * remove kwargs in ConcatScheduler.simulate_values * fix: remove unused mypy ignore Co-authored-by: vfdev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1665
Fixes #1665
Description:
Check list: