Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added missing args to ModelCheckpoint, parity with Checkpoint #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vfdev-5 merged 4 commits into from
Feb 20, 2022
Merged

Added missing args to ModelCheckpoint, parity with Checkpoint #2486

vfdev-5 merged 4 commits into from
Feb 20, 2022

Conversation

@vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Feb 20, 2022 •
edited
Loading

Fixes #2482
Fixes #2475

Description:

  • Added missing args to ModelCheckpoint, parity with Checkpoint
  • Updated Checkpoint.last_checkpoint

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: handlers Core Handlers module label Feb 20, 2022
@vfdev-5 vfdev-5 requested a review from sdesrozis February 20, 2022 00:04
@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Feb 20, 2022

Related failure on windows:

E                   OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpheqvupwl\\tmpwbrvfpyv' -> 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpheqvupwl\\SAVE:model-acc-0.9999.pth'

@vfdev-5 vfdev-5 enabled auto-merge (squash) February 20, 2022 14:27
@vfdev-5 vfdev-5 merged commit 493d86d into pytorch:master Feb 20, 2022
@vfdev-5 vfdev-5 deleted the update-model-checkpoint branch February 20, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdesrozis sdesrozis Awaiting requested review from sdesrozis

Assignees

No one assigned

Labels

module: handlers Core Handlers module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uniformize {ModelCheckpoint,Checkpoint}.load_checkpoint Allow filename_pattern to be passed to ModelCheckpoint

1 participant

@vfdev-5