Modify all_reduce to take group
#2712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puhuk
commented
Sep 19, 2022
vfdev-5
reviewed
Sep 22, 2022
puhuk
commented
Sep 26, 2022
vfdev-5
reviewed
Sep 27, 2022
| if group is not None: | ||
| if not isinstance(group, hvd.ProcessSet): | ||
| raise ValueError("Argument group should be list of int or ProcessSet") | ||
| hvd.init(process_sets=[group]) |
Collaborator
There was a problem hiding this comment.
@puhuk do you know what hvd.init(process_sets=[group]) does ?
Contributor
Author
There was a problem hiding this comment.
Isn't it initialize the horovod to take process_sets with specified process set like group ?
Collaborator
There was a problem hiding this comment.
and how it works if horovod is already initialized ?
Contributor
Author
There was a problem hiding this comment.
It sets up the horovod backend again by calling _setup_process_sets. So it should not be called after already initialized ?
Contributor
Author
There was a problem hiding this comment.
There are two options in initializing horovod
- Static initialization like
hvd.init(process_sets= ~~)--> In this case, when initialized, process_set can not be changed - Dynamic process set like
hvd.init(process_sets="dynamic")--> In this case, process set can be altered dynamically
vfdev-5
reviewed
Sep 28, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Modify all_reduce to take
groupCheck list: