Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added every_before_after event filter #2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vfdev-5 merged 11 commits into from
Feb 14, 2023
Merged

Added every_before_after event filter #2860

vfdev-5 merged 11 commits into from
Feb 14, 2023

Conversation

@theory-in-progress
Copy link
Contributor

@theory-in-progress theory-in-progress commented Feb 10, 2023 •
edited by vfdev-5
Loading

Related to #2853

Description:

  • New Feature
  • Executes after every every Iterations
  • For after=8, before=25, every=5 Executes on Iterations 9 14 19 24

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@theory-in-progress
Added every_before_after event filter
09727ab 
* Executes after every `every` Iterations
* For after=8, before=25, every=5 Executes on Iterations 9 14 19 24
@github-actions github-actions bot added the module: engine Engine module label Feb 10, 2023
vfdev-5
vfdev-5 reviewed Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theory-in-progress thanks for the PR ! Please add tests, I think args checking wont pass

@theory-in-progress theory-in-progress marked this pull request as draft February 10, 2023 16:24
@theory-in-progress
Modified the Raise Error Condition
7d733cd 
* Raise Error condition according to the addition of the new feature of every iterations
@theory-in-progress
Added Docstring for every between after and before
2daee86
@theory-in-progress
Modified the condition for RaiseError when Invalid arguments passed
3e769d6 
* Edited the Function name of every_before_and_after_event_filter
@theory-in-progress
Added Tests for every after and before
e5c60af 
* Added all the variations that can be passed as arguments, using for loops
* Added test for every_before_and_after feature
vfdev-5
vfdev-5 reviewed Feb 13, 2023
View reviewed changes
vfdev-5
vfdev-5 reviewed Feb 13, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @theory-in-progress
I left few comments

vfdev-5
vfdev-5 reviewed Feb 14, 2023
View reviewed changes
vfdev-5
vfdev-5 reviewed Feb 14, 2023
View reviewed changes
@vfdev-5 vfdev-5 marked this pull request as ready for review February 14, 2023 13:11
vfdev-5
vfdev-5 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @theory-in-progress ! LGTM

@vfdev-5 vfdev-5 added this pull request to the merge queue Feb 14, 2023
This was referenced Feb 14, 2023
Closed
Closed
Merged via the queue into pytorch:master with commit c716ac5 Feb 14, 2023
@vfdev-5 vfdev-5 mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

module: engine Engine module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@theory-in-progress @vfdev-5