Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Test fbeta available device #3335 #3360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vfdev-5 merged 30 commits into from
Apr 16, 2025
Merged

Test fbeta available device #3335 #3360

vfdev-5 merged 30 commits into from
Apr 16, 2025

Conversation

@BanzaiTokyo
Copy link
Contributor

@BanzaiTokyo BanzaiTokyo commented Mar 27, 2025

No description provided.

vfdev-5
vfdev-5 reviewed Mar 28, 2025
View reviewed changes
vfdev-5
vfdev-5 reviewed Mar 28, 2025
View reviewed changes
vfdev-5
vfdev-5 reviewed Mar 28, 2025
View reviewed changes
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 28, 2025 •
edited
Loading

Let's also make the following check inside Fbeta implementation that if provided precision, recall metrics then device arg should None, same as this:

ignite/ignite/metrics/fbeta.py

Lines 149 to 150 in 795dccb

if recall is not None and output_transform is not None:
raise ValueError("If recall argument is provided, output_transform should be None")

Also let's change the default value here to None:

ignite/ignite/metrics/fbeta.py

Line 18 in 795dccb

device: Union[str, torch.device] = torch.device("cpu"),

If precision, recall are None and device is None then set device to cpu.

OK if you do that in a follow-up PR

@github-actions github-actions bot added the module: metrics Metrics module label Mar 29, 2025
vfdev-5
vfdev-5 reviewed Mar 29, 2025
View reviewed changes
vfdev-5
vfdev-5 reviewed Mar 29, 2025
View reviewed changes
vfdev-5
vfdev-5 reviewed Mar 29, 2025
View reviewed changes
vfdev-5
vfdev-5 reviewed Apr 15, 2025
View reviewed changes
vfdev-5
vfdev-5 reviewed Apr 15, 2025
View reviewed changes
vfdev-5
vfdev-5 reviewed Apr 15, 2025
View reviewed changes
vfdev-5
vfdev-5 reviewed Apr 16, 2025
View reviewed changes
vfdev-5
vfdev-5 approved these changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can merge as failures are unrelated to the PR

@vfdev-5 vfdev-5 merged commit abd80b8 into pytorch:master Apr 16, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees

No one assigned

Labels

module: metrics Metrics module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BanzaiTokyo @vfdev-5