Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Feature] Dispatch PPO loss module#1249

Merged
vmoens merged 1 commit intopytorch:mainfrom
Blonck:dispatch_ppo
Jun 9, 2023
Merged

[Feature] Dispatch PPO loss module#1249
vmoens merged 1 commit intopytorch:mainfrom
Blonck:dispatch_ppo

Conversation

@Blonck
Copy link
Contributor

@Blonck Blonck commented Jun 9, 2023

Description

Enable dispatching arguments for the .forward() method of the PPO loss module.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@Blonck Blonck added the enhancement New feature or request label Jun 9, 2023
@Blonck Blonck requested a review from vmoens June 9, 2023 08:48
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2023
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit a25a878 into pytorch:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants