[Algorithm] IMPALA and VTrace module#1506
Merged
vmoens merged 118 commits intopytorch:mainfrom Nov 23, 2023
Merged
Conversation
vmoens
reviewed
Sep 7, 2023
Co-authored-by: Vincent Moens <[email protected]>
Co-authored-by: Vincent Moens <[email protected]>
Co-authored-by: Vincent Moens <[email protected]>
Co-authored-by: Vincent Moens <[email protected]>
Co-authored-by: Vincent Moens <[email protected]>
Co-authored-by: Vincent Moens <[email protected]>
vmoens
approved these changes
Nov 23, 2023
Collaborator
vmoens
left a comment
There was a problem hiding this comment.
LGTM, can you edit the unused args?
| def forward( | ||
| self, | ||
| tensordict: TensorDictBase, | ||
| *unused_args, |
Collaborator
There was a problem hiding this comment.
I don't see them appearing after that, so I would suggest to do
def forward(
self,
tensordict: TensorDictBase,
*, ...for this and for GAE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a VTrace module to be able to run IMPALA (https://arxiv.org/abs/1802.01561)
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax
close #15213if this solves the issue #15213Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!