Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Feature] Add group_map support to MLAgents wrappers #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2024
Merged

[Feature] Add group_map support to MLAgents wrappers #2491

merged 1 commit into from
Oct 14, 2024

Conversation

kurtamohler
Copy link
Contributor

@kurtamohler kurtamohler commented Oct 11, 2024 •
edited by vmoens
Loading

Description

Adds the group_map argument to UnityMLAgentsWrapper and UnityMLAgentsEnv.

Motivation and Context

Close #2490

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • New feature (non-breaking change which adds core functionality)
  • Documentation (update in the documentation)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

cc @matteobettini

@kurtamohler kurtamohler added the Environments Adds or modifies an environment wrapper label Oct 11, 2024
@kurtamohler kurtamohler requested a review from vmoens October 11, 2024 17:06
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2491

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 9 Unrelated Failures

As of commit c57d1d9 with merge base ec04c35 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 11, 2024
vmoens
vmoens approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super useful
LGTM thanks!

@vmoens vmoens merged commit ad14594 into pytorch:main Oct 14, 2024
65 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmoens vmoens vmoens approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add group_map support to MLAgents wrappers

3 participants

@kurtamohler @vmoens @facebook-github-bot