Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Deprecation] Change the default MLP depth #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2025
Merged

[Deprecation] Change the default MLP depth #2746

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82ccc3a
Update
Feb 3, 2025
09c4a8e
Update
Feb 3, 2025
51e29e5
Update
Feb 3, 2025
a5bee75
Update
Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions torchrl/modules/models/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from __future__ import annotations

import dataclasses
import warnings

from copy import deepcopy
from numbers import Number
Expand Down Expand Up @@ -51,6 +50,7 @@ class MLP(nn.Sequential):
argument (see below). If ``num_cells`` is an iterable and depth is
indicated, both should match: ``len(num_cells)`` must be equal to
``depth``.
Defaults to ``0`` (no depth - the network contains a single linear layer).
num_cells (int or sequence of int, optional): number of cells of every
layer in between the input and output. If an integer is provided,
every layer will have the same number of cells. If an iterable is provided,
Expand Down Expand Up @@ -181,17 +181,10 @@ def __init__(
raise ValueError("out_features must be specified for MLP.")

if num_cells is None:
warnings.warn(
"The current behavior of MLP when not providing `num_cells` is that the number of cells is "
"set to [default_num_cells] * depth, where `depth=3` by default and `default_num_cells=0`. "
"From v0.7, this behavior will switch and `depth=0` will be used. "
"To silence tis message, indicate what number of cells you desire.",
category=DeprecationWarning,
)
default_num_cells = 32
if depth is None:
num_cells = [default_num_cells] * 3
depth = 3
num_cells = []
depth = 0
else:
num_cells = [default_num_cells] * depth

Expand Down
Loading